fix(reconcile): made cross repo more robust #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| failOnError( | ||
| c.PersistentFlags().MarkDeprecated("repo", `please use "repository" flag instead.`), | ||
| "reconcile", | ||
| ) | ||
| c.PersistentFlags().StringVar(&repositoryName, "repository", "", "The name of the gihtub repository.") | ||
| c.PersistentFlags().StringVar(&repositoryName, "repository", "", "The name of the TARGET github repository.") |
There was a problem hiding this comment.
Do you not need the repository of the source branch at all?
There was a problem hiding this comment.
Nope. It should always be the repository of the target branch. In the case where the branches belong to different repositories, it will be automatically handled by the remotes we provide.
blackhatcrazy
approved these changes
Sep 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scenario where we are reconciling between repositories, we now automatically raise a PR in the target repository with the replicated source branch. Hence improving the UX.
In-order to achieve the above, we have to make sure that the ownerName and repositoryName provided in the command is that of the target repository, so that after replicating the source to the target repository, we can reconcile between the source replica and target branch in the target branch repository.