Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(platform): add cellActivate event to platform table #11875

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

mikerodonnell89
Copy link
Member

fixes #11639

Decided to piggyback on the rowActivate event. This works similarly, it just passes columnIndex instead of the row index. Also, row does not need to be activable. WIP because I am open to name suggestions

@mikerodonnell89 mikerodonnell89 added this to the Sprint 134 - May 2024 milestone May 2, 2024
@mikerodonnell89 mikerodonnell89 requested a review from a team May 2, 2024 17:51
@mikerodonnell89 mikerodonnell89 self-assigned this May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Visit the preview URL for this PR (updated for commit dc6313c):

https://fundamental-ngx-gh--pr11875-fix-11639-ng17-mxcz7fyn.web.app

(expires Sun, 05 May 2024 17:53:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Copy link

netlify bot commented May 2, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit dc6313c
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6633d2a00cf0da000843a5c8
😎 Deploy Preview https://deploy-preview-11875--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mikerodonnell89 mikerodonnell89 changed the title [WIP] fix(platform): add cellActivate event to platform table fix(platform): add cellActivate event to platform table May 3, 2024
@droshev droshev added the accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support label May 7, 2024
@droshev droshev merged commit a714061 into main May 7, 2024
18 of 19 checks passed
@droshev droshev deleted the fix/11639-ng17 branch May 7, 2024 17:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sourcing][P1] Can we have cells clickable in fdp-table
2 participants