Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(platform): check validator before open Filtering Settings Dialog #11878

Merged

Conversation

oscargong
Copy link
Member

@oscargong oscargong commented May 3, 2024

PR #11535 added validator input for p13 filter component.

But it caused a regression, when there is no <fdp-table-p13n-filter [validator]="validator" /> inside

<fdp-table-p13-dialog [table]="table"> </fdp-table-p13-dialog>

Table filter cannot be opened.

This issue can be reproduced on both 0.49 and 0.43

Copy link

netlify bot commented May 3, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 87cd12f
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6638e37679400d00089f1999
😎 Deploy Preview https://deploy-preview-11878--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 3, 2024

Visit the preview URL for this PR (updated for commit 87cd12f):

https://fundamental-ngx-gh--pr11878-oscar-platform-table-fvqks7y7.web.app

(expires Thu, 09 May 2024 14:13:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@oscargong oscargong force-pushed the Oscar/platform-table-filtering-regressin branch from 56069c6 to def34ca Compare May 3, 2024 21:57
@droshev droshev added the ng15 Angular 15 support label May 3, 2024
@droshev droshev added this to the Sprint 134 - May 2024 milestone May 3, 2024
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscargong Did you commit with --no-verify? The linter was throwing an error. You'll likely see this problem with the main branch as well. I have pushed a fix to this PR. Thanks!

@mikerodonnell89 mikerodonnell89 merged commit a012cdc into ng-15-downport May 6, 2024
19 checks passed
@mikerodonnell89 mikerodonnell89 deleted the Oscar/platform-table-filtering-regressin branch May 6, 2024 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ng15 Angular 15 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants