Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(core): user settings #13041

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(core): user settings #13041

wants to merge 7 commits into from

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Feb 13, 2025

Related Issue(s)

closes #13042

Description

adds new component in Core called Settings Dialog

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit ebc5f37
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/67c9b179415bb30008ddf981
😎 Deploy Preview https://deploy-preview-13041--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InnaAtanasova InnaAtanasova force-pushed the feat/settings branch 2 times, most recently from 248674f to d214aba Compare February 14, 2025 15:23
@InnaAtanasova InnaAtanasova changed the title [wip]feat(core): user settings feat(core): user settings Feb 17, 2025
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing between text on the settings with byline list looks a little off to me, looks like the text container has less padding. Intentional?

Byline list:
Screenshot 2025-03-04 at 12 10 29 PM

user settings:
Screenshot 2025-03-04 at 12 15 25 PM

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the fundamental-styles docs I can see that the content is aligned with the dialog title:
Screenshot 2025-03-04 at 12 17 57 PM

It is a bit off on this PR:
Screenshot 2025-03-04 at 12 18 36 PM

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings component UXC
3 participants