Skip to content

golangBuild: update golangci-lint version #3952

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Conversation

vstarostin
Copy link
Member

@vstarostin vstarostin commented Aug 10, 2022

Changes

  • Tests
  • Documentation

We are using golangci-lint version v1.46.2 and we started getting errors:

21:34:08  info  golangBuild - running command: ./install.sh -b /go/bin v1.46.2
21:34:08  info  golangBuild - golangci/golangci-lint info checking GitHub for tag 'v1.46.2'
21:34:09  info  golangBuild - golangci/golangci-lint info found version: 1.46.2 for v1.46.2/linux/amd64
21:34:11  info  golangBuild - golangci/golangci-lint info installed /go/bin/golangci-lint
21:34:11  info  golangBuild - running command: /go/bin/golangci-lint run --out-format checkstyle
21:34:18  info  golangBuild - panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
21:34:18  info  golangBuild - 
21:34:18  info  golangBuild - goroutine 1 [running]:
21:34:18  info  golangBuild - github.com/go-critic/go-critic/checkers.init.22()
21:34:18  info  golangBuild - 	github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4
21:34:18  info  golangBuild - fatal error: errorDetails{"category":"undefined","correlationId":"https://jenkins.piper.c.eu-de-2.cloud.sap/job/Testing/job/Vyacheslav%20Starostin/job/golang-build-piper/21/","error":"running golangci-lint failed: running command '/go/bin/golangci-lint' failed: cmd.Run() failed: exit status 2","library":"","message":"execution of golang build failed","result":"failure","stepName":"golangBuild","time":"2022-08-09T15:34:17.800365264Z"}
21:34:18  fatal golangBuild - execution of golang build failed - running golangci-lint failed: running command '/go/bin/golangci-lint' failed: cmd.Run() failed: exit status 2

golangci-lint issues:
golangci/golangci-lint#2374
go-critic/go-critic#1157
golangci/golangci-lint#2649
golangci/golangci-lint#2414

golangci-lint with the latest (v1.48.0) version works fine.

21:30:09  info  golangBuild - golangci/golangci-lint info checking GitHub for tag 'latest'
21:30:10  info  golangBuild - golangci/golangci-lint info found version: 1.48.0 for v1.48.0/linux/amd64
21:30:11  info  golangBuild - golangci/golangci-lint info installed /go/bin/golangci-lint
21:30:11  info  golangBuild - running command: /go/bin/golangci-lint run --out-format checkstyle
21:30:15  info  golangBuild - lint report: 
21:30:15  <?xml version="1.0" encoding="UTF-8"?>
21:30:15  
21:30:15  <checkstyle version="5.0">
21:30:15  </checkstyle>
21:30:15  
21:30:15  info  golangBuild - writing lint report to golangci-lint-report.xml

@vstarostin vstarostin requested a review from a team as a code owner August 10, 2022 14:45
@vstarostin vstarostin requested a review from a team August 10, 2022 14:47
@jliempt
Copy link
Member

jliempt commented Aug 10, 2022

/it

1 similar comment
@vstarostin
Copy link
Member Author

/it

@vstarostin vstarostin merged commit 65a637c into master Aug 11, 2022
@vstarostin vstarostin deleted the vstarostin/golangcilint branch August 11, 2022 08:21
maksd pushed a commit to maxatsap/jenkins-library that referenced this pull request Aug 18, 2022
Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants