Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(tests): disable parallel execution of integration tests #5269

Merged
merged 4 commits into from
Feb 14, 2025
Merged

fix(tests): disable parallel execution of integration tests #5269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6f7bdc
try disabling t.Parallel()
Feb 13, 2025
72451d7
Merge branch 'master' into gulom/fix_it
Googlom Feb 13, 2025
246ceef
Merge branch 'master' into gulom/fix_it
Googlom Feb 13, 2025
7906e61
Merge branch 'master' into gulom/fix_it
Googlom Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions integration/integration_cnb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func setupDockerRegistry(t *testing.T, ctx context.Context) testcontainers.Conta
}

func TestCNBIntegrationNPMProject(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand Down Expand Up @@ -86,7 +86,7 @@ func TestCNBIntegrationNPMProject(t *testing.T) {
}

func TestCNBIntegrationProjectDescriptor(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand Down Expand Up @@ -116,7 +116,7 @@ func TestCNBIntegrationProjectDescriptor(t *testing.T) {
container.terminate(t)
}
func TestCNBIntegrationBuildSummary(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand All @@ -141,7 +141,7 @@ func TestCNBIntegrationBuildSummary(t *testing.T) {
}

func TestCNBIntegrationZipPath(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand Down Expand Up @@ -170,7 +170,7 @@ func TestCNBIntegrationZipPath(t *testing.T) {
}

func TestCNBIntegrationNonZipPath(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand All @@ -190,7 +190,7 @@ func TestCNBIntegrationNonZipPath(t *testing.T) {
}

func TestCNBIntegrationNPMCustomBuildpacksFullProject(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand Down Expand Up @@ -218,7 +218,7 @@ func TestCNBIntegrationNPMCustomBuildpacksFullProject(t *testing.T) {
}

func TestCNBIntegrationNPMCustomBuildpacksBuildpacklessProject(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand All @@ -245,7 +245,7 @@ func TestCNBIntegrationNPMCustomBuildpacksBuildpacklessProject(t *testing.T) {
}

func TestCNBIntegrationWrongBuilderProject(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "nginx:latest",
TestDir: []string{"testdata", "TestMtaIntegration", "npm"},
Expand All @@ -259,7 +259,7 @@ func TestCNBIntegrationWrongBuilderProject(t *testing.T) {
}

func TestCNBIntegrationBindings(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand Down Expand Up @@ -287,7 +287,7 @@ func TestCNBIntegrationBindings(t *testing.T) {
}

func TestCNBIntegrationMultiImage(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand Down Expand Up @@ -321,7 +321,7 @@ func TestCNBIntegrationMultiImage(t *testing.T) {
}

func TestCNBIntegrationPreserveFiles(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand All @@ -341,7 +341,7 @@ func TestCNBIntegrationPreserveFiles(t *testing.T) {
}

func TestCNBIntegrationPreserveFilesIgnored(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand All @@ -360,7 +360,7 @@ func TestCNBIntegrationPreserveFilesIgnored(t *testing.T) {
}

func TestCNBIntegrationPrePostBuildpacks(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
registryContainer := setupDockerRegistry(t, ctx)
defer registryContainer.Terminate(ctx)
Expand Down
4 changes: 2 additions & 2 deletions integration/integration_gauge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@ cd /test
}

func TestGaugeIntegrationJava(t *testing.T) {
t.Parallel()
// t.Parallel()
runTest(t, "java")
}

func TestGaugeIntegrationJS(t *testing.T) {
t.Parallel()
// t.Parallel()
runTest(t, "js")
}
2 changes: 1 addition & 1 deletion integration/integration_gcs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
)

func TestGCSIntegrationClient(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
testdataPath, err := filepath.Abs("testdata/TestGCSIntegration")
assert.NoError(t, err)
Expand Down
4 changes: 2 additions & 2 deletions integration/integration_github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
)

func TestGitHubIntegrationPiperPublishRelease(t *testing.T) {
t.Parallel()
// t.Parallel()
token := os.Getenv("PIPER_INTEGRATION_GITHUB_TOKEN")
if len(token) == 0 {
t.Fatal("No GitHub token maintained")
Expand Down Expand Up @@ -95,7 +95,7 @@ func TestGitHubIntegrationPiperPublishRelease(t *testing.T) {
}

func TestGitHubIntegrationFetchCommitStatistics(t *testing.T) {
t.Parallel()
// t.Parallel()
// prepare
token := os.Getenv("PIPER_INTEGRATION_GITHUB_TOKEN")
if len(token) == 0 {
Expand Down
6 changes: 3 additions & 3 deletions integration/integration_golang_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
// In this test the piper command golangBuild performs testing, BOM file creation and building a project with entry point in the cmd/server/server.go
// The configuration for golangBuild can be found in testdata/TestGolangIntegration/golang-project1/.pipeline/config.yml
func TestGolangIntegrationBuildProject1(t *testing.T) {
t.Parallel()
// t.Parallel()

container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "golang:1",
Expand Down Expand Up @@ -51,7 +51,7 @@ func TestGolangIntegrationBuildProject1(t *testing.T) {

// This test extends TestGolangIntegrationBuildProject1 with multi-package build
func TestGolangIntegrationBuildProject1MultiPackage(t *testing.T) {
t.Parallel()
// t.Parallel()

container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "golang:1",
Expand Down Expand Up @@ -88,7 +88,7 @@ func TestGolangIntegrationBuildProject1MultiPackage(t *testing.T) {
// In this test, the piper golangBuild command only builds the project with the entry point at the project root.
// The configuration for golangBuild can be found in testdata/TestGolangIntegration/golang-project2/.pipeline/config.yml
func TestGolangIntegrationBuildProject2(t *testing.T) {
t.Parallel()
// t.Parallel()

container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "golang:1",
Expand Down
4 changes: 2 additions & 2 deletions integration/integration_gradle_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

func TestGradleIntegrationExecuteBuildJavaProjectBOMCreationUsingWrapper(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()

pwd, err := os.Getwd()
Expand Down Expand Up @@ -92,7 +92,7 @@ ls -l ./build/reports/ >files-list.txt 2>&1
}

func TestGradleIntegrationExecuteBuildJavaProjectWithBomPlugin(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()

pwd, err := os.Getwd()
Expand Down
2 changes: 1 addition & 1 deletion integration/integration_influx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
)

func TestInfluxIntegrationWriteMetrics(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
const authToken = "influx-token"
const username = "username"
Expand Down
2 changes: 1 addition & 1 deletion integration/integration_karma_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
func TestKarmaIntegration(t *testing.T) {
t.Skip("Skip failing test for now")

t.Parallel()
// t.Parallel()
ctx := context.Background()

pwd, err := os.Getwd()
Expand Down
4 changes: 2 additions & 2 deletions integration/integration_maven_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
)

func TestMavenIntegrationBuildCloudSdkSpringProject(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "maven:3-openjdk-8-slim",
User: "1000",
Expand Down Expand Up @@ -46,7 +46,7 @@ func TestMavenIntegrationBuildCloudSdkSpringProject(t *testing.T) {
}

func TestMavenIntegrationBuildCloudSdkTomeeProject(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "maven:3-openjdk-8-slim",
User: "1000",
Expand Down
8 changes: 4 additions & 4 deletions integration/integration_mta_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
)

func TestMTAIntegrationMavenProject(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "devxci/mbtci-java11-node14",
User: "root",
Expand All @@ -33,7 +33,7 @@ func TestMTAIntegrationMavenProject(t *testing.T) {
}

func TestMTAIntegrationMavenSpringProject(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "devxci/mbtci-java11-node14",
User: "root",
Expand All @@ -54,7 +54,7 @@ func TestMTAIntegrationMavenSpringProject(t *testing.T) {
}

func TestMTAIntegrationNPMProject(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "devxci/mbtci-java11-node14",
User: "root",
Expand All @@ -71,7 +71,7 @@ func TestMTAIntegrationNPMProject(t *testing.T) {
}

func TestMTAIntegrationNPMProjectInstallsDevDependencies(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "devxci/mbtci-java11-node14",
User: "root",
Expand Down
6 changes: 3 additions & 3 deletions integration/integration_nexus_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func assertFileCanBeDownloaded(t *testing.T, container IntegrationTestDockerExec
}

func TestNexusIntegrationV3UploadMta(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "sonatype/nexus3:3.25.1",
User: "nexus",
Expand All @@ -57,7 +57,7 @@ func TestNexusIntegrationV3UploadMta(t *testing.T) {
}

func TestNexusIntegrationV3UploadMaven(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "sonatype/nexus3:3.25.1",
User: "nexus",
Expand All @@ -84,7 +84,7 @@ func TestNexusIntegrationV3UploadMaven(t *testing.T) {
}

func TestNexusIntegrationV3UploadNpm(t *testing.T) {
t.Parallel()
// t.Parallel()
container := givenThisContainer(t, IntegrationTestDockerExecRunnerBundle{
Image: "sonatype/nexus3:3.25.1",
User: "nexus",
Expand Down
8 changes: 4 additions & 4 deletions integration/integration_npm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
)

func TestNPMIntegrationRunScriptsWithOptions(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()

pwd, err := os.Getwd()
Expand Down Expand Up @@ -70,7 +70,7 @@ cd /test
}

func TestNPMIntegrationRegistrySetInFlags(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()

pwd, err := os.Getwd()
Expand Down Expand Up @@ -121,7 +121,7 @@ cd /test
}

func TestNPMIntegrationRegistrySetInNpmrc(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()

pwd, err := os.Getwd()
Expand Down Expand Up @@ -172,7 +172,7 @@ cd /test
}

func TestNPMIntegrationRegistryWithTwoModules(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()

pwd, err := os.Getwd()
Expand Down
2 changes: 1 addition & 1 deletion integration/integration_piper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
)

func TestPiperIntegrationHelp(t *testing.T) {
t.Parallel()
// t.Parallel()
piperHelpCmd := command.Command{}

var commandOutput bytes.Buffer
Expand Down
2 changes: 1 addition & 1 deletion integration/integration_python_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

func TestPythonIntegrationBuildProject(t *testing.T) {
t.Parallel()
// t.Parallel()
ctx := context.Background()
pwd, err := os.Getwd()
assert.NoError(t, err, "Getting current working directory failed.")
Expand Down
6 changes: 3 additions & 3 deletions integration/integration_sonar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
)

func TestSonarIntegrationIssueSearch(t *testing.T) {
t.Parallel()
// t.Parallel()
// init
token := os.Getenv("PIPER_INTEGRATION_SONAR_TOKEN")
require.NotEmpty(t, token, "SonarQube API Token is missing")
Expand Down Expand Up @@ -52,7 +52,7 @@ func TestSonarIntegrationIssueSearch(t *testing.T) {
}

func TestSonarIntegrationMeasuresComponentSearch(t *testing.T) {
t.Parallel()
// t.Parallel()
// init
token := os.Getenv("PIPER_INTEGRATION_SONAR_TOKEN")
require.NotEmpty(t, token, "SonarQube API Token is missing")
Expand All @@ -77,7 +77,7 @@ func TestSonarIntegrationMeasuresComponentSearch(t *testing.T) {
}

func TestSonarIntegrationGetLinesOfCode(t *testing.T) {
t.Parallel()
// t.Parallel()
// init
token := os.Getenv("PIPER_INTEGRATION_SONAR_TOKEN")
require.NotEmpty(t, token, "SonarQube API Token is missing")
Expand Down
Loading
Loading