-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(ui5-table): improve default column widths #11078
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as I said we should not try to be smart with the column templates but this continues in this change.
what i expect is having a single width property(1fr by default) for the column, no min/max width and cells have the min-width: 3rem in their css. we document that the cell should not be less than 3rem. With the width property of the column they can make it smaller than 3rem but this is not our problem anymore.
lets discuss on monday again.
Instead of using
auto
as default width, the table columns will default to1fr
. This allows table columns to equally take the available space.This ensures the column's default width does not depend on the column content, leading to a more stable experience.
Additional changes:
max-width
Fixes #10536
Fixes #11051
Partially fixes #10716