Change copyTpl to have the same function signature as copy so it canaccept more options
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can accept more options Fixes SBoudrias#25
|
@SBoudrias The API change is a breaking change. |
|
Hum, I'm not sure about this one... That's a very major breaking change. Anyway we could hack our way around breaking existing api? |
|
We could, but I think this make things more consistent. |
|
Would it be sufficient to only allow passing glob object as path? (ref #26) |
|
Actually I think that's an option too. |
|
Yeah, because this is too big of a breaking change. We wouldn't be able to bump it in Yeoman any time soon... |
|
I'll close this PR as we won't follow on this code path. Thanks for the work anyway! |
|
NP :) I will try to find time to implemented what we agree on. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25