add apfElement to exported interface #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In mumfim we make direct use of the element. @maxrpi @cwsmith and @jacobmerson discussed this offline a few months ago and felt like this was a reasonable fix.
|
/runtests |
|
Test Result: failure (details) |
|
The build with simmetrix enabled, and most of the tests were successful. The handful of failing tests (https://github.com/SCOREC/core/actions/runs/9861918501/job/27231422235#step:3:3460) are unrelated to this PR; see #434. |
cwsmith
approved these changes
Jul 9, 2024
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mumfim we make direct use of the element. @maxrpi @cwsmith and @jacobmerson discussed this offline a few months ago and felt like this was a reasonable fix.