support Cabana backend #48
Conversation
…orked on copying over kokkos tests to test cabana
|
@Joshua-Kloepfer Thanks for addressing the items. Can you describe how the recursive baseType struct for defining ValArray works? |
| coordField(i, 0, 0, MeshField::Vertex) = coords[i * meshDim]; | ||
| coordField(i, 0, 1, MeshField::Vertex) = coords[i * meshDim + 1]; |
There was a problem hiding this comment.
We should document the change in the field indexing order to 'entity, node, component'. For now I think the best spot for that description is on this function:
Line 183 in 3b72eb0
src/MeshField_Element.hpp
Outdated
| template <typename T> struct baseType { | ||
| using type = T; | ||
| }; | ||
| template <typename T, size_t N> struct baseType<T[N]> { | ||
| using type = typename baseType<T>::type; | ||
| }; |
There was a problem hiding this comment.
Please add a brief description of why this is needed and how it works.
| Controller<ExecutionSpace, MemorySpace, DataType>, | ||
| MeshField::CabanaController<ExecutionSpace, MemorySpace, | ||
| DataType>>) { | ||
| return Ctrlr(std::max(numVtx, numEdge)); |
There was a problem hiding this comment.
The controller needs to provide field storage for all the vertices and all the edges. It looks like this is selecting the higher of the two. Am I reading this correctly?
There was a problem hiding this comment.
Yes. The Cabana Controller accepts one number for the number of tuples so I picked the larger one to make sure there was enough space for both vertices and edges.
|
@Joshua-Kloepfer Please address the few comments above when you get a chance. Thanks for adding the the |
This PR adds support for the Cabana backend for field creation through the high level/user API.
Todo:
baseTypestruct does for definingValArraycreateCoordinateField(...)and just useDataType[1][3]in the cab controllernumComps == 1|2increateCoordinateField(...)