Skip to content

Fix for removed Event Inheritance #287

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2024
Merged

Fix for removed Event Inheritance #287

merged 2 commits into from
Jul 21, 2024

Conversation

AlexAUT
Copy link
Contributor

@AlexAUT AlexAUT commented Jul 20, 2024

Event inheritance was removed in SFML3. I can also split the lambda into two if that is preferred over the auto parameter.

@AlexAUT AlexAUT changed the title Fixs for removed Event Inheritance Fix for removed Event Inheritance Jul 20, 2024
@ChrisThrasher
Copy link
Member

ChrisThrasher commented Jul 21, 2024 •
edited
Loading

Looks like we need to update the examples to handle how pollEvent now returns a std::optional<sf::Event> rather than just an sf::Event. Would you mind fixing that real quick?

@AlexAUT
Copy link
Contributor Author

AlexAUT commented Jul 21, 2024

You can also close #285 after this one is merged.

@ChrisThrasher
Copy link
Member

You can also close #285 after this one is merged.

lol I forgot to merge my own PR. My bad.

@ChrisThrasher ChrisThrasher merged commit 4bebb4e into SFML:master Jul 21, 2024
25 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ChrisThrasher ChrisThrasher ChrisThrasher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAUT @ChrisThrasher