Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cleaned up mappings #639

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Cleaned up mappings #639

merged 10 commits into from
Oct 23, 2023

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Sep 10, 2023

Description

Removed everything that has been moved to tripper from mappings.py and import it from tripper instead.

This PR should not be merged into master before PR EMMC-ASBL/tripper#132 has been merged and preferable a new release of tripper has been created.

This cleanup was already done a while ago. Not sure why the old version of mappings.py has reappeared...

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Removed everything that has been moved to tripper from mappings.py and
import it from tripper instead.
@jesper-friis jesper-friis requested a review from sygout September 13, 2023 10:48
@sygout sygout requested review from quaat and removed request for sygout September 14, 2023 07:02
@jesper-friis jesper-friis requested review from francescalb and removed request for quaat October 11, 2023 09:06
@CasperWA CasperWA linked an issue Oct 11, 2023 that may be closed by this pull request
@ajeklund
Copy link
Contributor

Tripper PR 132 has now been merged. EMMC-ASBL/tripper#132

@ajeklund ajeklund self-requested a review October 18, 2023 11:36
@ajeklund
Copy link
Contributor

Tripper PR 132 has now been merged. EMMC-ASBL/tripper#132

All checks now passing, with tripper v0.2.10 (released today).

Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now works, with the latest release of tripper (v0.2.10). Please also update the requirements file to tripper v0.2.10 or greater.

@ajeklund
Copy link
Contributor

The tripper version requirement needs to be aligned with #648 (which currently also has tripper>=0.2.5,<0.3 in its new file requirements_mappings.txt).

@jesper-friis
Copy link
Collaborator Author

The tripper version requirement needs to be aligned with #648 (which currently also has tripper>=0.2.5,<0.3 in its new file requirements_mappings.txt).

Updated requirements on tripper to 0.2.10. The requirements_mappings.txt file will be updated in the PR where it is added

@jesper-friis jesper-friis requested a review from ajeklund October 23, 2023 12:48
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@jesper-friis jesper-friis merged commit 951a355 into master Oct 23, 2023
@jesper-friis jesper-friis deleted the mappings-cleanup branch October 23, 2023 13:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLite without full not working
2 participants