-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cleaned up mappings #639
Cleaned up mappings #639
Conversation
Removed everything that has been moved to tripper from mappings.py and import it from tripper instead.
Tripper PR 132 has now been merged. EMMC-ASBL/tripper#132 |
All checks now passing, with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now works, with the latest release of tripper
(v0.2.10). Please also update the requirements file to tripper
v0.2.10 or greater.
The |
Updated requirements on tripper to 0.2.10. The requirements_mappings.txt file will be updated in the PR where it is added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Description
Removed everything that has been moved to tripper from mappings.py and import it from tripper instead.
This PR should not be merged into master before PR EMMC-ASBL/tripper#132 has been merged and preferable a new release of tripper has been created.
This cleanup was already done a while ago. Not sure why the old version of mappings.py has reappeared...
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.