[refactor] 이미지 압축, PHPickerResult -> UIImage 변환 과정 병렬처리 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JongHoooon
commented
Jul 13, 2023
•
JongHoooon
commented
- [Refactor] 글씨기 image 업로드시 압축과정 병렬 처리 필요 #125
- [refactor] 글쓰기 화면에서 PHPickerResult -> UIImage 병렬처리 필요 #141
사진 순서 맞추는 작업을 global queue에서 병렬처리돼 return 값으로 [] 값이 반환돼 발생하는 문제 수정
seungwon-yoo
approved these changes
Jul 15, 2023
This was referenced Jul 15, 2023
JongHoooon
added a commit
that referenced
this pull request
Jul 17, 2023
* [refactor] DispatchGroup 사용해 image compress 작업 병렬 처리 * [refactor] zip 사용해 PHPickerResult -> UIImage 변환 과정 병렬 처리 * [Fix] 사진 순서 정렬 작업 순서 수정 사진 순서 맞추는 작업을 global queue에서 병렬처리돼 return 값으로 [] 값이 반환돼 발생하는 문제 수정 * [refactor] do 에 있는 로직 onNext, onError로 이동
JongHoooon
added a commit
that referenced
this pull request
Jul 17, 2023
* [refactor] DispatchGroup 사용해 image compress 작업 병렬 처리 * [refactor] zip 사용해 PHPickerResult -> UIImage 변환 과정 병렬 처리 * [Fix] 사진 순서 정렬 작업 순서 수정 사진 순서 맞추는 작업을 global queue에서 병렬처리돼 return 값으로 [] 값이 반환돼 발생하는 문제 수정 * [refactor] do 에 있는 로직 onNext, onError로 이동
JongHoooon
added a commit
that referenced
this pull request
Jul 17, 2023
* [refactor] DispatchGroup 사용해 image compress 작업 병렬 처리 * [refactor] zip 사용해 PHPickerResult -> UIImage 변환 과정 병렬 처리 * [Fix] 사진 순서 정렬 작업 순서 수정 사진 순서 맞추는 작업을 global queue에서 병렬처리돼 return 값으로 [] 값이 반환돼 발생하는 문제 수정 * [refactor] do 에 있는 로직 onNext, onError로 이동
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.