Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI fixes #1087

Merged
merged 10 commits into from
Mar 15, 2022
Merged

CI fixes #1087

merged 10 commits into from
Mar 15, 2022

Conversation

rkm
Copy link
Member

@rkm rkm commented Mar 4, 2022

Proposed Changes

  • Fixes the build scripts to respect any intermediate non-zero return codes
  • Fixes the build scripts to only build linux-x64 and win-x64
  • Fixes the build scripts to select the correct build configuration
  • Removes a bogus test leftover from Remove invalid extraction modality check. Fixes #1059 #1089
  • Temporarily disables a few tests requiring a fix for the leptonica libs

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm
Copy link
Member Author

rkm commented Mar 4, 2022

This should become unblocked once #1042 is merged

@rkm rkm changed the title ensure return codes from called scripts are respected CI fixes Mar 15, 2022
@rkm rkm requested a review from tznind March 15, 2022 15:41
@rkm rkm merged commit 999647c into master Mar 15, 2022
@rkm rkm deleted the fix/ci-forward-return-codes branch March 15, 2022 17:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants