Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support extraction validation failure #1259

Merged
merged 8 commits into from
Aug 29, 2022

Conversation

rkm
Copy link
Member

@rkm rkm commented Aug 10, 2022

Proposed Changes

Enable the extraction validation service (IsIdentifiable) to indicate that it was unable to scan a file, in order to distinguish processing errors from a validation pass/fail status.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm marked this pull request as ready for review August 10, 2022 15:22
@rkm rkm requested a review from tznind August 10, 2022 15:22
@rkm rkm merged commit f0e8c56 into master Aug 29, 2022
@rkm rkm deleted the feature/extraction-validation-failure branch August 29, 2022 14:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants