Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add development support for ARM / M1 Mac #1428

Merged
merged 9 commits into from
Feb 1, 2023
Merged

Add development support for ARM / M1 Mac #1428

merged 9 commits into from
Feb 1, 2023

Conversation

rkm
Copy link
Member

@rkm rkm commented Jan 13, 2023

Proposed Changes

Adds build targets for ARM and allows developers with M1 Macs to build.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

@rkm rkm force-pushed the meta/arm-support branch from d97f697 to ee551f0 Compare January 28, 2023 11:13
@rkm
Copy link
Member Author

rkm commented Jan 28, 2023

@darshad-github Could you pull the latest commit and try both of the following, then let me know if either produces an error?

$ dotnet clean
$ dotnet build
$ dotnet test --list-tests
$ ./bin/smi/buildTestPackage.py --clean --test none tag

@darshad-github
Copy link
Contributor

@darshad-github Could you pull the latest commit and try both of the following, then let me know if either produces an error?

$ dotnet clean
$ dotnet build
$ dotnet test --list-tests
$ ./bin/smi/buildTestPackage.py --clean --test none tag

@rkm project builds successfully, however, gives the following error upon executing dotnet test --list-tests:

Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Could not find 'dotnet' host for the 'X64' architecture.

@rkm rkm marked this pull request as ready for review February 1, 2023 16:26
@rkm rkm requested a review from darshad-github February 1, 2023 16:26
@rkm rkm merged commit 9a3fcb1 into master Feb 1, 2023
@rkm rkm deleted the meta/arm-support branch February 1, 2023 16:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants