Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adopt central package management #1451

Merged
merged 11 commits into from
Mar 10, 2023
Merged

Conversation

rkm
Copy link
Member

@rkm rkm commented Feb 18, 2023

Proposed Changes

https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm force-pushed the meta/central-package-management branch 2 times, most recently from a934958 to 0f47930 Compare February 19, 2023 19:16
@rkm rkm force-pushed the meta/central-package-management branch from 0f47930 to 27b15fa Compare February 19, 2023 19:23
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (be8b4a5) 67.86% compared to head (d3cc6a8) 67.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
+ Coverage   67.86%   67.87%   +0.01%     
==========================================
  Files         185      185              
  Lines        6544     6544              
==========================================
+ Hits         4441     4442       +1     
+ Misses       2103     2102       -1     
Impacted Files Coverage Δ
...er/Messaging/DicomRelationalMapperQueueConsumer.cs 75.18% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rkm rkm marked this pull request as ready for review March 10, 2023 16:20
@rkm rkm requested a review from jas88 March 10, 2023 16:21
@jas88 jas88 merged commit c860ab7 into master Mar 10, 2023
@jas88 jas88 deleted the meta/central-package-management branch March 10, 2023 21:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants