enable nullable

[rkm]

Proposed Changes

Enable the C# nullable feature and fix all warnings.

Many of the ! annotations around the GlobalOptions types are awkward since they are publicly set-able and can be null depending on what's loaded from the YAML config, but it's a good start.

Types of changes

What types of changes does your code introduce? Tick all that apply.

• Bugfix (non-breaking change which fixes an issue)
• New Feature (non-breaking change which adds functionality)
• Breaking Change (fix or feature that would cause existing functionality to not work as expected)
• Documentation-Only Update (if none of the other choices apply)
  • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

• Reviewed the contributing guidelines for this repository
• Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
• Updated any relevant API documentation
• Created or updated any tests if relevant
• Created a news file
  • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
• Listed myself in the CONTRIBUTORS file 🚀
• Requested a review by one of the repository maintainers

Issues

• Closes Enable nullable types #719

[codecov]

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (e330901) 68.44% compared to head (05b4d6e) 68.56%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
+ Coverage   68.44%   68.56%   +0.11%     
==========================================
  Files         185      185              
  Lines        6510     6550      +40     
==========================================
+ Hits         4456     4491      +35     
- Misses       2054     2059       +5     

Files	Coverage Δ
...Execution/DirectoryFinders/DicomDirectoryFinder.cs	80.39% <100.00%> (+2.13%)	⬆️
...essor/Options/DicomDirectoryProcessorCliOptions.cs	42.85% <100.00%> (-10.09%)	⬇️
...c/applications/Applications.DicomLoader/Program.cs	80.00% <100.00%> (ø)
...cations/Applications.DynamicRulesTester/Program.cs	100.00% <100.00%> (ø)
...ions/Applications.ExtractImages/CohortCsvParser.cs	100.00% <100.00%> (ø)
...lications.ExtractImages/ExtractImagesCliOptions.cs	30.00% <100.00%> (ø)
...ns/Applications.ExtractImages/ExtractImagesHost.cs	97.72% <100.00%> (-2.28%)	⬇️
...lications.ExtractImages/ExtractionMessageSender.cs	100.00% <100.00%> (ø)
...ons.TriggerUpdates/Execution/TriggerUpdatesHost.cs	100.00% <100.00%> (ø)
...Updates/Options/TriggerUpdatesFromMapperOptions.cs	100.00% <100.00%> (ø)
... and 123 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jas88]

@rkm Probably better using ? rather than ! for a lot of those aren't we? Good idea though, I'll take a closer look when I'm officially back from AL!

[rkm]

@jas88 do you have capacity to review this? I can get someone else to review if not 😃

[jas88]

@rkm yep - now RDMP 8.1.0 is out I'll try to do this one later today

[rkm]

force merging this without a review so as to unblock other PRs