-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/1443 add username to extraction metadata #1663
Feature/1443 add username to extraction metadata #1663
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
+ Coverage 58.79% 58.87% +0.07%
==========================================
Files 185 185
Lines 6546 6563 +17
Branches 913 915 +2
==========================================
+ Hits 3849 3864 +15
- Misses 2434 2435 +1
- Partials 263 264 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we should check how the missing UserName field is handled. Thanks!
...ervices.CohortPackager/Execution/ExtractJobStorage/MongoDB/ObjectModel/MongoExtractJobDoc.cs
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
fix pre-commit formatting
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably review the serialization and validation logic separately, but this PR looks good to me! Thanks
Proposed Changes
Adding field
UserName
toExtractionRequestInfoMessage
, which is read into MongoDB.Types of changes
What types of changes does your code introduce? Tick all that apply.
[skip ci]
Checklist
By opening this PR, I confirm that I have:
Issues
If relevant, tag any issues that are expected to be resolved with this PR. E.g.: