Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/1443 add username to extraction metadata #1663

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

karacolada
Copy link
Member

@karacolada karacolada commented Nov 6, 2023

Proposed Changes

Adding field UserName to ExtractionRequestInfoMessage, which is read into MongoDB.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

@karacolada karacolada requested a review from rkm November 6, 2023 14:48
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5ecd558) 58.79% compared to head (b5c0bc1) 58.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
+ Coverage   58.79%   58.87%   +0.07%     
==========================================
  Files         185      185              
  Lines        6546     6563      +17     
  Branches      913      915       +2     
==========================================
+ Hits         3849     3864      +15     
- Misses       2434     2435       +1     
- Partials      263      264       +1     
Files Coverage Δ
...lications.ExtractImages/ExtractionMessageSender.cs 99.11% <100.00%> (+0.02%) ⬆️
...essages/Extraction/ExtractionRequestInfoMessage.cs 100.00% <100.00%> (ø)
...ution/ExtractJobStorage/CompletedExtractJobInfo.cs 93.75% <100.00%> (+0.41%) ⬆️
...obStorage/MongoDB/MongoExtractJobInfoExtensions.cs 100.00% <100.00%> (ø)
...ecution/JobProcessing/Reporting/JobReporterBase.cs 96.66% <100.00%> (-0.36%) ⬇️
...bStorage/MongoDB/ObjectModel/MongoExtractJobDoc.cs 86.20% <80.00%> (-0.38%) ⬇️
...ager/Execution/ExtractJobStorage/ExtractJobInfo.cs 61.53% <50.00%> (-0.97%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rkm rkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should check how the missing UserName field is handled. Thanks!

Copy link
Member

@rkm rkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably review the serialization and validation logic separately, but this PR looks good to me! Thanks

@karacolada karacolada merged commit 6af14c1 into master Nov 9, 2023
@rkm rkm deleted the feature/1443-add-username-to-extraction-metadata branch January 18, 2024 20:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add username to extraction metadata
2 participants