Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

disable debug logging spam from external CTP libraries #1671

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

rkm
Copy link
Member

@rkm rkm commented Nov 17, 2023

Proposed Changes

Prevents a vast number of function calls being logged per processed file. Resulted in a ~10x speedup in CTP execution on our testing.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a39eac2) 58.90% compared to head (daef91a) 58.81%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   58.90%   58.81%   -0.10%     
==========================================
  Files         185      185              
  Lines        6563     6563              
  Branches      915      915              
==========================================
- Hits         3866     3860       -6     
- Misses       2431     2437       +6     
  Partials      266      266              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm changed the title adjust java logging to INFO level only disable debug logging spam from external CTP libraries Nov 20, 2023
@rkm rkm marked this pull request as ready for review November 20, 2023 14:24
@rkm rkm requested a review from a team November 20, 2023 14:24
@rkm rkm merged commit ae242dc into master Nov 20, 2023
@rkm rkm deleted the fix/java-logging branch January 18, 2024 20:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTP logging too verbose CTPAnonymiser logs internal debug spam
2 participants