Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/system private uri vuln #2012

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix/system private uri vuln #2012

merged 2 commits into from
Nov 20, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Nov 20, 2024

Proposed Changes

This was surfaced when attempting to upgrade to .NET 9 SDK. See dotnet/announcements#113

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

rkm added 2 commits November 20, 2024 14:23
This was surfaced when attempting to upgrade to .NET 9 SDK. See
dotnet/announcements#113
@rkm rkm force-pushed the fix/system-private-uri-vuln branch from c65cf8c to 5b3ed21 Compare November 20, 2024 14:25
@rkm rkm marked this pull request as ready for review November 20, 2024 14:26
@rkm rkm enabled auto-merge (rebase) November 20, 2024 14:26
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.78%. Comparing base (706d252) to head (5b3ed21).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2012   +/-   ##
=======================================
  Coverage   64.78%   64.78%           
=======================================
  Files         183      183           
  Lines        6560     6560           
  Branches      965      965           
=======================================
  Hits         4250     4250           
  Misses       2023     2023           
  Partials      287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rkm rkm merged commit 368ea13 into main Nov 20, 2024
19 checks passed
@rkm rkm deleted the fix/system-private-uri-vuln branch November 20, 2024 14:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant