Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixup newline parsing in CohortPackager #581

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

rkm
Copy link
Member

@rkm rkm commented Feb 8, 2021

Proposed Changes

Fixes a bug where newlines would never be correctly parsed from the config option in CohortPackager.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

Drops the old ParseToCsvNewLine method since CsvHelper deals with newline strings directly now.
@rkm rkm requested a review from 2bPro February 8, 2021 17:51
@rkm rkm self-assigned this Feb 8, 2021
Copy link
Contributor

@2bPro 2bPro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without running it I can't tell exactly what it does but the bug fix looks like it helped clean up some code as well.

@rkm rkm merged commit 14e6f4b into master Feb 9, 2021
@rkm rkm deleted the bugfix/cohort-packager-newline-2 branch February 9, 2021 09:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants