Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

manually update csvhelper to 25.0.0, fo-dicom to 4.0.7 #592

Merged
merged 10 commits into from
Mar 3, 2021

Conversation

rkm
Copy link
Member

@rkm rkm commented Feb 15, 2021

Proposed Changes

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm
Copy link
Member Author

rkm commented Feb 15, 2021

Remaining failures caused by upstream BadMedicine DICOM lib

@rkm
Copy link
Member Author

rkm commented Feb 22, 2021

Need to bump this to 24.0.1

@rkm rkm changed the title manually update csvhelper to 23.0.0 manually update csvhelper to 25.0.0 Feb 25, 2021
@rkm rkm force-pushed the csvhelper-update branch from d201b31 to 506834b Compare February 25, 2021 18:05
@rkm
Copy link
Member Author

rkm commented Mar 2, 2021

@jas88 I think we also need a release of BadMedicine.Dicom to bring-in the API updates

@jas88
Copy link
Contributor

jas88 commented Mar 2, 2021

@jas88 I think we also need a release of BadMedicine.Dicom to bring-in the API updates

Good point - SMI/BadMedicine.Dicom#38 in the queue now

@rkm rkm changed the title manually update csvhelper to 25.0.0 manually update csvhelper to 25.0.0, fo-dicom to 4.0.7 Mar 2, 2021
@rkm rkm requested a review from jas88 March 3, 2021 13:24
@jas88 jas88 merged commit 7c7273d into master Mar 3, 2021
@jas88 jas88 deleted the csvhelper-update branch March 3, 2021 15:13
rkm added a commit that referenced this pull request Mar 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants