Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Require all tests to pass before packaging #788

Merged
merged 5 commits into from
Jun 12, 2021
Merged

Conversation

rkm
Copy link
Member

@rkm rkm commented Jun 11, 2021

Proposed Changes

AP forces you to manually check if the dependsOn tasks have succeeded otherwise it will always continue.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm force-pushed the fix/package-conditional branch from 0ebe718 to 6c7a947 Compare June 11, 2021 11:55
@rkm rkm force-pushed the fix/package-conditional branch from 742df78 to 53bcb1b Compare June 11, 2021 12:07
@rkm rkm marked this pull request as ready for review June 11, 2021 12:09
@rkm rkm requested a review from tznind June 11, 2021 12:09
@rkm rkm self-assigned this Jun 11, 2021
@coveralls
Copy link

coveralls commented Jun 11, 2021

Coverage Status

Coverage remained the same at 54.12% when pulling 6930a8b on fix/package-conditional into 707f262 on master.

@tznind
Copy link
Contributor

tznind commented Jun 11, 2021

Does this effectively change the CI to only release the package if all tests pass? That seems sensible but doesn't match the changelog/news/PR title. Maybe "Changed package release CI task to require all tests to pass"?

@rkm
Copy link
Member Author

rkm commented Jun 11, 2021

True - the fix was mainly that I had always intended that to be the case! Will update the docs

@rkm rkm changed the title Fix package conditional Require all tests to pass before packaging Jun 11, 2021
@rkm rkm merged commit 3392963 into master Jun 12, 2021
@rkm rkm deleted the fix/package-conditional branch June 12, 2021 09:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants