Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix setting replication for MongoDB in Windows CI pipelines #877

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

rkm
Copy link
Member

@rkm rkm commented Jul 29, 2021

Proposed Changes

As above, caused by MongoDB version upgrade in Windows build agents: actions/runner-images#3749. This should be able to handle version upgrades in future without further code changes.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm force-pushed the meta/mongodb-win-version-fix branch from 82e6ee2 to 96a4f7c Compare July 29, 2021 10:40
@coveralls
Copy link

coveralls commented Jul 29, 2021

Coverage Status

Coverage increased (+3.0%) to 52.278% when pulling c4cd057 on meta/mongodb-win-version-fix into 73d4e67 on master.

@rkm rkm merged commit 94aa22e into master Jul 29, 2021
@rkm rkm deleted the meta/mongodb-win-version-fix branch July 29, 2021 11:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants