Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure control exchange exists for ExtractImagesHostTests #917

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

rkm
Copy link
Member

@rkm rkm commented Sep 28, 2021

Proposed Changes

Fixes current CI test failures.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm changed the title ensure control exchange exists for ExtractImagesHostTests Ensure control exchange exists for ExtractImagesHostTests Sep 28, 2021
@rkm rkm self-assigned this Sep 28, 2021
@rkm rkm marked this pull request as ready for review September 28, 2021 11:53
@rkm rkm requested a review from tznind September 28, 2021 11:59
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 51.835% when pulling dabae71 on fix/test-control-exchange into 4776373 on master.

@rkm rkm merged commit a09e4e3 into master Sep 28, 2021
@rkm rkm deleted the fix/test-control-exchange branch September 28, 2021 13:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants