Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

allow newer minor sdk versions #923

Merged
merged 3 commits into from
Oct 9, 2021
Merged

allow newer minor sdk versions #923

merged 3 commits into from
Oct 9, 2021

Conversation

rkm
Copy link
Member

@rkm rkm commented Oct 7, 2021

Proposed Changes

Allow newer minor SDK versions to build the sln. global.json specifies the minimum version which will be used in the CI.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Meta
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

@rkm rkm force-pushed the fix/global-json-rollforward branch from 28312c0 to 8451646 Compare October 7, 2021 18:09
@rkm rkm force-pushed the fix/global-json-rollforward branch from 8451646 to e11fff7 Compare October 7, 2021 18:10
@rkm rkm merged commit 233cb22 into master Oct 9, 2021
@rkm rkm deleted the fix/global-json-rollforward branch October 9, 2021 10:53
@rkm rkm mentioned this pull request Oct 12, 2021
11 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SmiServices currently wants an exact SDK installed in order to build
2 participants