Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add implementation of the multi-fi cokriging MFCK (2 fidelity levels) #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcastanoUQ
Copy link

No description provided.

@relf relf changed the title First implementations of the MFCK (Any dimmensions, 2 fidelity levels) Add implementation of the multi-fi cokriging MFCK (2 fidelity levels) Sep 3, 2024
Copy link
Member

@relf relf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mauricio, a few requests on your PR:

  • you have to rebase your branch on top of current master (and resolve the small conflict),
  • you have to pass ruff 0.6 (linting, formatting) on your code
  • you have too many blank lines (please take a look at some other code in SMT)
  • remove print statements (you can use SMT printer mechanism if needs be)
  • you have to add some tests in dedicated tests/test_mfck.py file

@mcastanoUQ
Copy link
Author

Thank you so much for the comments, I'll check every point

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants