Wrap ConsumerGroup.onRebalance to avoid waterfall bug (#922)

If the onRebalance function yields a value, it would be reflected into the waterfall and move the callback to the 2nd parameter. see #918
SOHU-Co · Apr 10, 2018 · 0f5bce3 · 0f5bce3
1 parent 1531175
commit 0f5bce3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/consumerGroup.js b/lib/consumerGroup.js
@@ -442,7 +442,12 @@ ConsumerGroup.prototype.connect = function () {
     [
       function (callback) {
         if (typeof self.options.onRebalance === 'function') {
-          self.options.onRebalance(self.generationId != null && self.memberId != null, callback);
+          self.options.onRebalance(self.generationId != null && self.memberId != null, function (error) {
+            if (error) {
+              return callback(error);
+            }
+            callback(null);
+          });
           return;
         }
         callback(null);