Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Api Docs Consumer.commit #296

Closed
ansgarS opened this issue Jan 5, 2016 · 1 comment · Fixed by #306
Closed

Api Docs Consumer.commit #296

ansgarS opened this issue Jan 5, 2016 · 1 comment · Fixed by #306

Comments

@ansgarS
Copy link

ansgarS commented Jan 5, 2016

In readme you describe Consumer.commit:

Consumer.commit(cb)

But in Consumer.js commit needs two params:

function autoCommit(force, cb) { ... }

Consumer.prototype.commit = Consumer.prototype.autoCommit = autoCommit;
@estliberitas estliberitas mentioned this issue Jan 10, 2016
Merged
@giaosudau
Copy link

Is that commit to zookeeper or kafka?

@haio haio closed this as completed in #306 Feb 21, 2016
carlessistare pushed a commit to carlessistare/kafka-node that referenced this issue Apr 26, 2016
@estliberitas @carlessistare
Make commit() method of Consumer and HighLevelConsumer handle c…
f01156b 
…ase when only callback is passed

Fixes SOHU-Co#296
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make commit() handle case when only callback is passed
2 participants
@giaosudau @ansgarS