Race condition when closing client, still attempt to refreshBrokerMetadata when client is closing #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OH man this may be one of the missing pieces of my #907 PR. I'm all for this landing/being merged separate from my PR though as I'm still working on test failures for it, but I'll pull this to my local fork and should hopefully finally fix the hangs I still occasionally get! |
|
Interesting state of this PR, it seems like you have some commits for IPv6, that shows up in https://patch-diff.githubusercontent.com/raw/SOHU-Co/kafka-node/pull/1048.patch, but doesn't in the diff view... So confused on what's going on there heh. |
|
@aikar Previously, I had a PR fix for IPv6 support and that commit got merged into master branch. |
aikar
approved these changes
Aug 17, 2018
There was a problem hiding this comment.
@hyperlink I've had this pulled to my fork lately, this is good w/ me
hyperlink
approved these changes
Aug 30, 2018
|
Published as 3.0.0 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've filed an issue regarding this commit, please refer to #1045. There is a race condition when broker is disconnecting and Kafka client sometimes still attempts to refreshBrokerMetadata when client is closing.