Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

KafkaClient should not refresh metadata when broker socket is closed … #1216

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

hyperlink
Copy link
Collaborator

…due to being idle

@crobinson42
Copy link
Contributor

It appears this test fails on all builds in Travis 🔨
#removeTopics
1) "after all" hook: close consumer group

https://github.com/SOHU-Co/kafka-node/blob/master/test/test.consumerGroup.js#L1123

@crobinson42
Copy link
Contributor

This will cause:

kafka-node:KafkaClient kafka-node-client to 192.168.0.151:9092 is idle not reconnecting +10m

What do you think about adding a param to force reconnecting when idle in this scenario?

@crobinson42
Copy link
Contributor

Something like new KafkaClient({ reconnectOnIdle: true })

@hyperlink
Copy link
Collaborator Author

It appears this test fails on all builds in Travis 🔨
#removeTopics

  1. "after all" hook: close consumer group

https://github.com/SOHU-Co/kafka-node/blob/master/test/test.consumerGroup.js#L1123

Yup that is one of the flaky tests. 😒

Something like new KafkaClient({ reconnectOnIdle: true })

Not against adding this. PR?

@hyperlink hyperlink merged commit 488e9a9 into master Mar 27, 2019
@hyperlink hyperlink deleted the no-refresh-on-idle branch March 27, 2019 14:33
KeeReal pushed a commit to KeeReal/kafka-node that referenced this pull request Apr 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants