Contributing guidelines

[carlessistare]

Some guidelines for contributors and code reviewers to be followed

[estliberitas]

Well, non-contributers won't be able to create topic branch. They will have to fork.

UPDATE: Ah, sorry, I did not read top section. Anyways, better to mention that one is to work with fork )

[estliberitas]

Maybe recommend to squash commits? That would help with clean commit history.

[hyperlink]

Didn't github just add squashed merges?

[estliberitas]

Until @haio enables rebase-like merge, I recommend we use rebase instead of merge to avoid those "Merge ...." commits.

https://github.com/blog/2141-squash-your-commits

[carlessistare]

@estliberitas I agree, I added a comment with this.

[ultrafez]

There's a typo in the word "history" here

[estliberitas]

@haio Will you add squash style merging soon? I'd like to use it )

[carlessistare]

The problem of this, is that we cannot easily revert PR am I wrong?
I usually use squash style to merge differet feature PRed in a feature
branch, but not in master, in order to be able unmerge in case of problems.
What do you think?

Le mar. 5 avr. 2016 à 00:13, Alexander Makarenko notifications@github.com
a écrit :

@haio https://github.com/haio Will you add squash style merging soon?
I'd like to use it )

—
You are receiving this because you authored the thread.

Reply to this email directly or view it on GitHub
#346 (comment)

[estliberitas]

@carlessistare Well, I did not see if github does it for this new feature. If it does not have "Revert" button, then it will be a kinda issue but not that big one.

[hyperlink]

Squash merge is available.