enable ssl client connections to brokers (#334) #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om a group of topics populating those topics partitions
| self.brokerProfiles[addr] = brokerProfile; | ||
| if (self.ssl) { | ||
| var sslAddress = brokerProfile.endpoints.find(function(endpoint) { | ||
| return endpoint.startsWith('SSL://'); |
There was a problem hiding this comment.
this won't work in 0.12.14 and below.
| return new Client(host, clientId, undefined, undefined, sslOptions); | ||
| } | ||
|
|
||
| describe(suiteName, function () { |
There was a problem hiding this comment.
everything after this is just indenting to put it inside of the forEach above.
|
Feedback on this PR @haio or @estliberitas ? |
|
Thank you for your contribution @CharlesWall ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ssl socket for client/broker connections. only works with +0.9