Adding new util function for topics validations #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving the `validateTopics` topics function as it is because I believe it is meant for validating the topics coming from the `send()` function. Not sure, though. `validateCreateTopics` contains following checks which are similar to what is been done for Kafka here [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/common/Topic.scala] - check if the topic is empty. - check if the topic is . or .. - check if the topic length is greater than 249 characters. - check if the topic, is not ASCII alphanumeric.
For build fix.
hyperlink
requested changes
Oct 25, 2016
| throw new InvalidConfigError('topic name cannot be . or ..'); | ||
| } | ||
| if (topic.length > allowedTopicLength) { | ||
| throw new InvalidConfigError('topic name is illegal, cannot be longer than ' + allowedTopicLength + ' characters'); |
There was a problem hiding this comment.
Do you mind changing to a template literal? We support node 4 now.
|
|
||
| function validateConfig (property, value) { | ||
| if (!legalChars.test(value)) { | ||
| throw new InvalidConfigError([property, value, "is illegal, contains a character other than ASCII alphanumerics, '.', '_' and '-'"].join(' ')); | ||
| } | ||
| } | ||
|
|
||
| function validateCreateTopics (topics) { |
There was a problem hiding this comment.
Maybe rename this to validateTopicNames since this isn't specific to just creating topics but we can reuse this to validate topics in the other classes.
| @@ -1,13 +1,34 @@ | |||
| var assert = require('assert'); | |||
| var InvalidConfigError = require('./errors/InvalidConfigError'); | |||
| var legalChars = new RegExp('^[a-zA-Z0-9._-]*$'); | |||
| var allowedTopicLength = 249; | |||
| throw new InvalidConfigError('topic name is illegal, cannot be longer than ' + allowedTopicLength + ' characters'); | ||
| } | ||
| if (!legalChars.test(topic)) { | ||
| throw new InvalidConfigError('topic name ' + topic + 'is illegal, contains a character other than ASCII alphanumerics .,_ and -'); |
There was a problem hiding this comment.
template literal here as well.
Fixes as per suggestion.
hyperlink
approved these changes
Oct 25, 2016
|
Done with the changes. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving the
validateTopicstopics function as it is because I believe it is meant for validating the topics coming from thesend()function. Not sure, though.validateCreateTopicscontains following checks which are similar to what is been done for Kafka here [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/common/Topic.scala]