Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Check buffer length before processing #657

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Check buffer length before processing #657

merged 2 commits into from
Apr 20, 2017

Conversation

crzidea
Copy link
Member

@crzidea crzidea commented Apr 20, 2017

Found a bug on data handling. Buffer could be empty between new incoming data arrived and setImmediate() callback be called

@crzidea crzidea requested a review from hyperlink April 20, 2017 10:32
@hyperlink hyperlink merged commit 7753238 into SOHU-Co:master Apr 20, 2017
hyperlink added a commit that referenced this pull request May 8, 2017
@hyperlink
Revert "Check buffer length before processing (#657)"
ba76d1d 
This reverts commit 7753238.
hyperlink added a commit that referenced this pull request May 8, 2017
@hyperlink
Fix #669 by revert bl change (#670)
b77c199 

* Revert "Check buffer length before processing (#657)"

This reverts commit 7753238.

* Revert "Merge pull request #654 from crzidea/bl"

This reverts commit 2ac4153, reversing
changes made to 88abf37.

* keep docker change
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hyperlink hyperlink hyperlink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crzidea @hyperlink