Added missing callbacks in the commit() #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperlink
reviewed
Oct 11, 2017
lib/consumerGroupStream.js
Outdated
| @@ -78,7 +78,7 @@ class ConsumerGroupStream extends Readable { | |||
|
|
|||
| if (this.committing && !force) { | |||
| logger.debug('skipping committing'); | |||
| return; | |||
| return callback && callback(); | |||
There was a problem hiding this comment.
can we explicitly pass in null arg here?
hyperlink
reviewed
Oct 11, 2017
lib/consumerGroupStream.js
Outdated
| @@ -94,7 +94,7 @@ class ConsumerGroupStream extends Readable { | |||
|
|
|||
| if (_.isEmpty(commits)) { | |||
| logger.debug('commit ignored. no commits to make.'); | |||
| return; | |||
| return callback && callback(); | |||
hyperlink
requested changes
Oct 11, 2017
|
@hyperlink Made the changes. Thanks. |
hyperlink
approved these changes
Oct 13, 2017
|
Thanks again. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing callback function in the code.
This is needed when stream.close() function is called and subsequent clean up happens.