Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add tslint, tslint-semistandard for typescript linting and reformat ts files #965

Merged
merged 1 commit into from
May 14, 2018

Conversation

zoltan-nz
Copy link
Contributor

  • Add tslint to package.json
  • Add tslint-config-semistandard library to package.json to align coding style to the main project
  • Add tslint configuration file to types folder.
  • Reformat .ts files.
  • Add test:ts script for devevlopment and testing.
  • Extend test node script with test:ts.

New npm script: npm run test:ts.

@zoltan-nz
Copy link
Contributor Author

@priithaamer @hyperlink Could you please review this PR? Thanks. :)

@zoltan-nz
Copy link
Contributor Author

@priithaamer Could you please relaunch the Travis test, for some reason, its timing out... Thanks. :)

Copy link
Collaborator

@hyperlink hyperlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@hyperlink hyperlink merged commit 1c07d7d into SOHU-Co:master May 14, 2018
thspinto pushed a commit to thspinto/kafka-node that referenced this pull request May 18, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants