chore(demo): reset player state before loading new media #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success142 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 9ce3357 |
jboix
reviewed
Dec 4, 2023
jboix
approved these changes
Dec 4, 2023
amtins
force-pushed
the
chore/demo-reset-player-state
branch
from
61c7738 to
671789b
Compare
Ensures that the player has been reset before loading new media. This prevents the old media being displayed for a fraction of the time before the new media is loaded. It also allows media without a poster to inherit the poster from the previous media. - reset player - reset error screen - reset title bar
amtins
force-pushed
the
chore/demo-reset-player-state
branch
from
671789b to
9ce3357
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that the player has been reset before loading new media. This prevents the old media being displayed for a fraction of the time before the new media is loaded. It also allows media without a poster to inherit the poster from the previous media.
Screencast.from.30.11.23.16.29.58.webm
Changes made