Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for multiple key bags, incl. rework of test files #65

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nitram509
Copy link

@nitram509 nitram509 commented Oct 30, 2024

This PR supersedes
#63 "Implement DecodeChains function that accepts multiple key bags"
and #64 "refactor tests to use static files, to ease development"
Resolves #62

It contains three main changes/enhancements

  • new function DecodeChains() supports decoding multiple safebags with private keys
  • refactored tests to use embed feature of go to ease test file creation and usage
  • splitting source files to separate pfx encoder and decoder logic, makes code more readable
  • fixes a bug in Implement DecodeChains function that accepts multiple key bags #63, when CA certificate chains contained duplicate certificates
  • improved documentation for users, to better guide, when to use what function (e.g. DecodeChain vs. DecodeTruststore)

Any feedback welcome.

@nitram509
Copy link
Author

Hi @AGWA may I ask for a review, please?

@marsskop
Copy link

marsskop commented Feb 7, 2025

Tests pass now:

$ go test                                                          
PASS
ok      software.sslmate.com/src/go-pkcs12      0.842s

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DecodeChains function that accepts multiple key bags
2 participants