118 code review feedback luke parker #84
This check has been archived and is scheduled for deletion.
Learn more about checks retention
GitHub Actions / Tests
succeeded
Nov 21, 2023 in 1s
Tests ✅
Report | Passed | Failed | Skipped | Time |
---|---|---|---|---|
Tests/Application.UnitTests/TestResults/TestResults.trx | 7✅ | 2s | ||
Tests/Domain.UnitTests/TestResults/TestResults.trx | 7✅ | 2s | ||
Tests/Infrastructure.IntegrationTests/TestResults/TestResults.trx | 1✅ | 59s | ||
Tests/WebUI.IntegrationTests/TestResults/TestResults.trx | 20✅ | 55s |
✅ Tests/Application.UnitTests/TestResults/TestResults.trx
7 tests were completed in 2s with 7 passed, 0 failed and 0 skipped.
Test suite | Passed | Failed | Skipped | Time |
---|---|---|---|---|
Northwind.Application.UnitTests.MappingTests | 7✅ | 133ms |
✅ Northwind.Application.UnitTests.MappingTests
✅ ShouldHaveValidConfiguration
✅ ShouldMapCategoryToCategoryLookupDto
✅ ShouldMapCustomerToCustomerDetailVm
✅ ShouldMapCustomerToCustomerLookupDto
✅ ShouldMapProductToProductDetailVm
✅ ShouldMapProductToProductDto
✅ ShouldMapProductToProductRecordDto
✅ Tests/Domain.UnitTests/TestResults/TestResults.trx
7 tests were completed in 2s with 7 passed, 0 failed and 0 skipped.
Test suite | Passed | Failed | Skipped | Time |
---|---|---|---|---|
Northwind.Domain.UnitTests.Common.CountryTests | 2✅ | 28ms | ||
Northwind.Domain.UnitTests.Common.PhoneTests | 2✅ | 19ms | ||
Northwind.Domain.UnitTests.Common.PostCodeTests | 2✅ | 20ms | ||
Northwind.Domain.UnitTests.Customers.CustomerTests | 1✅ | 223ms |
✅ Northwind.Domain.UnitTests.Common.CountryTests
✅ IsAustralia_GivenAustralianCountry_ReturnsTrue
✅ IsAustralia_GivenNonAustralianCountry_ReturnsFalse
✅ Northwind.Domain.UnitTests.Common.PhoneTests
✅ IsQueenslandLandline_GivenNonQLDNumber_ReturnsFalse
✅ IsQueenslandLandline_GivenQLDNumber_ReturnsTrue
✅ Northwind.Domain.UnitTests.Common.PostCodeTests
✅ IsQueenslandPostCode_GivenNonQLDPostCode_ReturnsFalse
✅ IsQueenslandPostCode_GivenQLDPostCode_ReturnsTrue
✅ Northwind.Domain.UnitTests.Customers.CustomerTests
✅ Handle_GivenValidRequest_ShouldRaiseCustomerCreatedNotification
✅ Tests/Infrastructure.IntegrationTests/TestResults/TestResults.trx
1 tests were completed in 59s with 1 passed, 0 failed and 0 skipped.
Test suite | Passed | Failed | Skipped | Time |
---|---|---|---|---|
Northwind.Infrastructure.IntegrationTests.NorthwindDbContextInitializerTests | 1✅ | 5s |
✅ Northwind.Infrastructure.IntegrationTests.NorthwindDbContextInitializerTests
✅ SeedAsync_AfterInitializeAsync_PopulatesDatabase
✅ Tests/WebUI.IntegrationTests/TestResults/TestResults.trx
20 tests were completed in 55s with 20 passed, 0 failed and 0 skipped.
✅ Northwind.WebUI.IntegrationTests.Endpoints.Categories.GetCategoryList
✅ ReturnsSuccessResult
✅ Northwind.WebUI.IntegrationTests.Endpoints.Customers.Create
✅ GivenCreateCustomerCommand_ReturnsSuccessStatusCode
✅ Northwind.WebUI.IntegrationTests.Endpoints.Customers.Delete
✅ GivenId_ReturnsSuccessStatusCode
✅ GivenInvalidId_ReturnsNotFoundStatusCode
✅ Northwind.WebUI.IntegrationTests.Endpoints.Customers.GetAll
✅ ReturnsCustomersListViewModel
✅ Northwind.WebUI.IntegrationTests.Endpoints.Customers.GetById
✅ GivenId_ReturnsCustomerViewModel
✅ GivenInvalidId_ReturnsNotFoundStatusCode
✅ Northwind.WebUI.IntegrationTests.Endpoints.Customers.Update
✅ GivenUpdateCustomerCommand_ReturnsSuccessStatusCode
✅ GivenUpdateCustomerCommandWithInvalidId_ReturnsNotFoundStatusCode
✅ Northwind.WebUI.IntegrationTests.Endpoints.Products.Create
✅ CreateProductCommand_WithNoCategory_CreatesProduct
✅ CreateProductCommand_WithNoSupplier_CreatesProduct
✅ CreateProductCommand_WithNoUnitPrice_CreatesProduct
✅ GivenCreateProductCommand_ReturnsNewProductId
✅ Northwind.WebUI.IntegrationTests.Endpoints.Products.Delete
✅ GivenId_ReturnsSuccessStatusCode
✅ GivenInvalidId_ReturnsNotFoundStatusCode
✅ Northwind.WebUI.IntegrationTests.Endpoints.Products.GetAll
✅ ReturnsProductsListViewModel
✅ Northwind.WebUI.IntegrationTests.Endpoints.Products.GetById
✅ GivenId_ReturnsProductViewModel
✅ GivenInvalidId_ReturnsNotFoundStatusCode
✅ Northwind.WebUI.IntegrationTests.Endpoints.Products.Update
✅ GivenUpdateProductCommand_ReturnsSuccessStatusCode
✅ GivenUpdateProductCommandWithInvalidId_ReturnsNotFoundStatusCode
Loading