-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
SHS-5987: Color contrast not meeting minimum requirement on email addresses over well background #1704
SHS-5987: Color contrast not meeting minimum requirement on email addresses over well background #1704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Looks good, but there are a couple of typos preventing the styles to be correctly applied.
docroot/themes/humsci/humsci_basic/src/scss/tools/_mixins.links.scss
Outdated
Show resolved
Hide resolved
docroot/themes/humsci/humsci_basic/src/scss/tools/_mixins.links.scss
Outdated
Show resolved
Hide resolved
@callinmullaney This is ready for review again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Confirming what Andres tested and that you addressed his feedback. Looks good to me!
…esses-over-well-background
@ahughes3 I've confirmed Andres feedback has been addressed and this PR looks good to me. Kicking this over to you for functional review. The Tugboat links were added as a PR comment but please let me know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
READY FOR REVIEW
Summary
Fix color contrast on links over well background
Urgency
medium
Steps to Test
hb-well
class for the component/admin/appearance/settings/humsci_colorful
PR Checklist