Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SHS-5987: Color contrast not meeting minimum requirement on email addresses over well background #1704

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jan 3, 2025

READY FOR REVIEW

Summary

Fix color contrast on links over well background

Urgency

medium

Steps to Test

  1. On any site that uses Colorful, create a Flexible Page
  2. Add a normal link (without any styles: e.g "External link") and a email address
  3. Save it and go to the layout tab of the page

Screenshot 2025-01-03 at 9 29 37 AM

  1. Add a hb-well class for the component

Screenshot 2025-01-03 at 9 29 46 AM

  1. Go to this path /admin/appearance/settings/humsci_colorful
  2. Change the Color Pairing to Canyon, Mountain and Ocean (this one was already included)
  3. And confirm the color of those links change when they are over well background and the color contrast meets accessibility

PR Checklist


Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Looks good, but there are a couple of typos preventing the styles to be correctly applied.

@ahughes3 ahughes3 temporarily deployed to Tugboat January 6, 2025 21:49 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat January 8, 2025 15:26 Destroyed
@mariannuar
Copy link
Collaborator Author

@callinmullaney This is ready for review again!

Base automatically changed from 11.6.1-release to develop January 8, 2025 16:39
Copy link
Collaborator

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Confirming what Andres tested and that you addressed his feedback. Looks good to me!

@ahughes3 ahughes3 temporarily deployed to Tugboat January 8, 2025 19:07 Destroyed
@callinmullaney callinmullaney assigned ahughes3 and unassigned mariannuar Jan 8, 2025
@callinmullaney
Copy link
Collaborator

@ahughes3 I've confirmed Andres feedback has been addressed and this PR looks good to me. Kicking this over to you for functional review. The Tugboat links were added as a PR comment but please let me know if you need anything else.

Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahughes3 ahughes3 assigned pookmish and unassigned ahughes3 Jan 13, 2025
@pookmish pookmish enabled auto-merge (squash) January 13, 2025 20:16
@pookmish pookmish disabled auto-merge January 13, 2025 22:03
@pookmish pookmish changed the base branch from develop to 11.6.3-release January 13, 2025 22:03
@pookmish pookmish merged commit 3e11ee0 into 11.6.3-release Jan 13, 2025
18 checks passed
@pookmish pookmish deleted the shs-5987-fix-color-contrast-on-email-addresses-over-well-background branch January 13, 2025 22:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants