Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CHEMH-265 | @jdwjdwjdw | Fixup event card template #92

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Mar 26, 2024

READY FOR REVIEW

Summary

  • CHEMH-265: Review ChEM-H subtheme for 5.2 release
  • This is a fixup for the event card - when an external source was added to an event, the card html structure/styles was not appearing correctly
    Screenshot 2024-03-26 at 12 12 16 PM

Review By (Date)

  • ASAP

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add an example event without an external source, and add an example event with an external source
  3. Add a basic page and test out event cards in teasers and lists
  4. Confirm that both event cards look correct
  5. Review code 🍩

Associated Issues and/or People

  • CHEMH-265: Review ChEM-H subtheme for 5.2 release

Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G

@jdwjdwjdw jdwjdwjdw merged commit 682059d into 2.x Mar 26, 2024
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the CHEMH-265--v5.2-fixups-v2 branch March 26, 2024 21:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants