Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ARCH-184 added images element and all necessary files to apply image defaults #175

Merged
merged 2 commits into from
Jul 19, 2018

Conversation

josephgknox
Copy link

@josephgknox josephgknox commented Jul 17, 2018

READY FOR REVIEW

Summary

  • Set defaults for images (margins, padding, height, width, and display), to help with responsiveness and layout

Needed By (Date)

  • As soon as possible (would unblock some project work)

Urgency

  • N/A

Steps to Test

  1. Pull this branch
  2. Ensure that the image element is displaying in the style guide and doing what added mixin suggests that it should

Affected Projects or Products

  • decanter
  • stanford_basic (theme)
  • suhumsci (theme), Archaeology project

Associated Issues and/or People

See Also

@josephgknox josephgknox requested review from sherakama and JBCSU July 17, 2018 19:07
@josephgknox
Copy link
Author

Cc: @bixgomez

@josephgknox josephgknox changed the title added images element and all necessary files to apply image defaults ARCH-184 added images element and all necessary files to apply image defaults Jul 17, 2018
@@ -0,0 +1 @@
<img src="{{ src }}" alt="{{ alt }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to use this template or is it just example?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an example. The mixin can be used as needed, but this was mostly to provide sensible defaults and provide an example for the pattern library.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I was going to suggest adding an {{ attributes }} variable so that developers could add additional attributes to the element tag.

eg: <img src="{{ src }}" alt="{{ alt }}" {{ attributes }}>

But perhaps we don't to dismay future developers from using this template.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more, do we even need an example for something like this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example page may be needed in the future. Perhaps for now, if we are not intending the developer to use the .twig file we put the markup directly in to the sass comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up and moved.

Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is fine to me.

@josephgknox
Copy link
Author

@sherakama there is an open ticket in a current sprint that ends soon that this works relates to. If this looks good (or needs more work), let me know. Hoping to get this merged.

@sherakama sherakama merged commit 2e7e1c3 into master Jul 19, 2018
@sherakama sherakama deleted the ARCH-155-image-default branch July 19, 2018 17:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants