Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

standards and enforcement #20

Merged
merged 9 commits into from
Feb 26, 2017
Merged

standards and enforcement #20

merged 9 commits into from
Feb 26, 2017

Conversation

sherakama
Copy link
Member

Some cleanup and a couple of changes.

  • Rename decanter-base.scss to _decanter-base.scss
  • When you remove the global defaults from the color mixin it turns in to just a pass through function. Can we remove it or change it to be useful again.
  • Removed neat-omega from the decanter-mixins roll up as it is not a part of this project. neat-omega should be imported where it is used only.
  • Added flex-container mixin to roll up
  • Removed all global variables from mixins and functions.

@kgcreative
Copy link
Contributor

I'm not opposed to renaming _retrieve-color to color and removing the pass-through function. The color function does need to call a default map, so it is dependent on it existing, but maybe the default map can be configured to accept a setting

Kevin Garcia and others added 3 commits February 25, 2017 20:26
todo: test wether we can remove the global color map from the function default call. In this case, this mixin *IS* set up to read from the global color map.
'neat';

'neat',
'omega';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omega is a custom neat module.

@kgcreative
Copy link
Contributor

This is ready to integrate if you you're good with it

@kgcreative kgcreative merged commit 2589233 into master Feb 26, 2017
@kgcreative kgcreative deleted the noglobal branch February 26, 2017 22:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants