Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conditionalize BPH helper output #33

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Conditionalize BPH helper output #33

merged 1 commit into from
Mar 15, 2017

Conversation

sherakama
Copy link
Member

Wraps the whole output of the id in a conditional in order to avoid markup bleeding

I'm getting this css outputted multiple times in my integrations as anytime I include the components roll up it gets put in. Can we go one step further and make this a mixin instead of a hard ID output?

I'm happy with just the conditional for now.

Copy link
Contributor

@kgcreative kgcreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A-OK By me. Let's add a issue for this. I want:

  • Breakpoint Helper to mixin
  • It should consume a map
  • The mixin iterates over the map (a la responsive container) and outputs all the breakpoints and colors as defined in the map.

@kgcreative kgcreative merged commit b1b3ff0 into master Mar 15, 2017
@kgcreative kgcreative deleted the bph branch March 15, 2017 18:03
@sherakama
Copy link
Member Author

Woot thanks. I'll add an issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants