Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use %placeholder and @extend on button mixins to see if it makes code less repetitive #347

Merged
merged 6 commits into from
Mar 20, 2019
Merged

Use %placeholder and @extend on button mixins to see if it makes code less repetitive #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c74ee74
testing using %placeholder and @extend on button component
yvonnetangsu Mar 18, 2019
1b8d5d2
add placeholder directory in utilities directory; move %button-base t…
yvonnetangsu Mar 18, 2019
fb2c833
Merge with master.
sherakama Mar 19, 2019
4fe24c9
Moved CTA from a mixin to a placeholder.
sherakama Mar 19, 2019
6ff9db9
fixup! wip.
sherakama Mar 19, 2019
a839773
fixup! wip.
sherakama Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
265 changes: 100 additions & 165 deletions core/css/decanter.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/scss/components/cta/_cta.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@
//

.su-cta {
@include cta;
@extend %cta-base;
}
18 changes: 15 additions & 3 deletions core/scss/utilities/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// Functions
//
// Programmatic procedure or routine to help making writing code or declaring
// something easier and more seamlesss.
// something easier and more seamless.
//
// Weight: -40
//
Expand All @@ -37,13 +37,25 @@
//
// Style guide: Mixins

//
// Placeholders
//
// Placeholders are reusable blocks of base CSS styles that can be used to reduce repetitiveness
// by using `@extend %placeholder;`.
// Placeholder styles do not show up in the compiled CSS file until a selector extends them.
//
// Weight: -30
//
// Style guide: Placeholders

// Load order convention exception
//
// The convention for importing files in index.scss files is to import in
// alphabetical order. This file intentionally breaks that convetion, as
// alphabetical order. This file intentionally breaks that convention, as
// variables need to be imported before functions and mixins.

@import
'variables/index',
'functions/index',
'mixins/index';
'mixins/index',
'placeholders/index';
Loading