Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace KSS nav with main-nav component #348

Merged
merged 13 commits into from
Mar 25, 2019
Merged

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Mar 19, 2019

READY FOR REVIEW

Summary

  • Replace the current nav on the styleguide website with the main-nav component now that we have a variant for dark backgrounds.
  • Add script to add --current class to appropriate nav items (and parent items) for styleguide.
  • Tweak variants of main-nav component. .su-main-nav--right now have mobile nav also right justified. .su-main-nav--center now have mobile nav also center justified.
  • Reorganize the links a bit - some items are in dropdowns.

Needed By (Date)

  • Before v.5 release if possible

Urgency

  • Not urgent

Steps to Test

  1. Pull this branch and run grunt styleguide.
  2. See if the website nav behaves the same as the main nav .su-main-nav--dark variant.

Affected Projects or Products

  • Decanter
  • Scott's event calendar

Associated Issues and/or People

Notes - a few small tweaks I added on the side....

  • Added link to brand logo "Decanter".
  • Added screen margins to decanter styleguide content for xs and sm breakpoints (was edge to edge).
  • Added a text-decoration: none for the lockup a element (found out I need that when doing Scott's calendar, the a element might be inheriting the underline from the style in the @link mixin).

* master:
  Cut down on media queries generated by @modular-spacing (#343)
* master:
  Refactor card component using placeholder and match Figma design (#332)
  Use %placeholder and @extend on button mixins to see if it makes code less repetitive (#347)

# Conflicts:
#	core/css/decanter.css
…, sm for styleguide site (except homepage); set no underline in lockup link
… hero section since we now have screen margins
@josephgknox
Copy link

@yvonnetangsu thanks for tackling this! It's nice to utilize our component in our own style guide. :)

Also: thanks for adding links to the other sections in the style guide, as well as pointing to important documentation elsewhere.

This looks good to me!

@yvonnetangsu
Copy link
Member Author

@sherakama , what do you think? Does this look ok?

Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@sherakama sherakama merged commit 84aa8a0 into master Mar 25, 2019
@sherakama sherakama deleted the 328-replace-kss-nav branch March 25, 2019 18:06
JBCSU added a commit that referenced this pull request Mar 26, 2019
* master:
  Replace KSS nav with main-nav component (#348)
  Refactor card component using placeholder and match Figma design (#332)

# Conflicts:
#	core/scss/components/card/_card.scss - resolved using master's
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants