-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace KSS nav with main-nav component #348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Cut down on media queries generated by @modular-spacing (#343)
…, sm for styleguide site (except homepage); set no underline in lockup link
… hero section since we now have screen margins
@yvonnetangsu thanks for tackling this! It's nice to utilize our component in our own style guide. :) Also: thanks for adding links to the other sections in the style guide, as well as pointing to important documentation elsewhere. This looks good to me! |
josephgknox
approved these changes
Mar 25, 2019
@sherakama , what do you think? Does this look ok? |
sherakama
approved these changes
Mar 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
.su-main-nav--right
now have mobile nav also right justified..su-main-nav--center
now have mobile nav also center justified.Needed By (Date)
Urgency
Steps to Test
grunt styleguide
..su-main-nav--dark
variant.Affected Projects or Products
Associated Issues and/or People
Notes - a few small tweaks I added on the side....