Font Loading Strategy #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherakama
force-pushed
the
fontloading
branch
4 times, most recently
from
8ada16c to
21a03c7
Compare
|
This is now ready for your wonderful direction and guidance. |
check for “not true” instead of “false” (default or un-instanced states can be true, false, null, default or a string). I specifically want to check for the absence of a “true” boolean setting) add a case for when we are passing this mixin a straight string or variable. Separate internal functions into stand-alone files (shea, we may need some discussion if a component contains variables, strings and functions, maybe we can instance this inside a parent folder that has it’s own structure?
|
@sherakama looks gooood! I made some edits, and tested it a bit further on this gist: http://www.sassmeister.com/gist/kgcreative/bcc81e611c0d8e53f94bc8228102025c |
flatten out the list
|
Addresses #7 |
Closed
josephgknox
pushed a commit
that referenced
this pull request
Feb 28, 2018
* EARTH-145: add classes to <body>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font loading strategy.