Create Masthead component #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and bar; modify box-shadow mixin to only write border property when needed
|
Also requesting your review in advance, @sherakama . I still need to add all the variables properly from the nested components and some fixup I need to do, but please leave any comments. I'm thinking for the different brand bar colors the developers can just pass in the brand bar modifier class themselves instead of having those as masthead variants. |
* master: DEC-381: Responsive flex classes with responsive gutters (#425)
…on top of each other
sherakama
reviewed
Jun 14, 2019
sherakama
reviewed
Jun 14, 2019
sherakama
reviewed
Jun 14, 2019
| @include grid-media-max('md') { | ||
| @include flex-column($columns: 10); | ||
| // On mobile, lockup needs a higher z-index than nav because the nav takes up 100% width including margin | ||
| z-index: 10010; |
There was a problem hiding this comment.
@buttonwillowsix z-index here.
sherakama
reviewed
Jun 14, 2019
sherakama
reviewed
Jun 14, 2019
sherakama
reviewed
Jun 14, 2019
sherakama
reviewed
Jun 14, 2019
sherakama
reviewed
Jun 14, 2019
yvonnetangsu
added a commit
that referenced
this pull request
Jun 17, 2019
* master: Create Masthead component (#439) Link variants (#450) Create TERMSOFUSE.txt (#441) 436 437 cards (#440) DEC-381: Responsive flex classes with responsive gutters (#425) # Conflicts: # core/dist/css/decanter.css # core/src/scss/components/card/_card.scss # core/src/scss/components/card/index.scss # core/src/scss/utilities/placeholders/components/_card.scss
JBCSU
added a commit
that referenced
this pull request
Jun 19, 2019
* master: date stacked component initial commit (#373) Add a variant for Card where the whole card is a link and add option to turn headline into a link (#444) Create Masthead component (#439) Link variants (#450) # Conflicts: # core/src/scss/utilities/mixins/link/_external-link.scss - resolved using master # core/src/scss/utilities/mixins/shadow/_box-shadow.scss - manually resolved
sherakama
pushed a commit
that referenced
this pull request
Jul 3, 2019
* Create a masthead component with multiple variants.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People